netdev - Re: [PATCH iproute v3 2/5] ila: Support for configuring ila to use netfilter hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160812130154.35c7deda@xeon-e3>
Date:	Fri, 12 Aug 2016 13:01:54 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Tom Herbert <tom@...bertland.com>
Cc:	<netdev@...r.kernel.org>, <kernel-team@...com>
Subject: Re: [PATCH iproute v3 2/5] ila: Support for configuring ila to use
 netfilter hook

On Tue, 9 Aug 2016 14:41:36 -0700
Tom Herbert <tom@...bertland.com> wrote:

> Signed-off-by: Tom Herbert <tom@...bertland.com>
> ---
>  ip/Makefile    |   2 +-
>  ip/ip.c        |   3 +-
>  ip/ip_common.h |   1 +
>  ip/ipila.c     | 268 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 272 insertions(+), 2 deletions(-)
>  create mode 100644 ip/ipila.c

You didn't fix this warning.

ipila.c: In function ‘ila_parse_opt.constprop’:
ipila.c:205:2: warning: ‘locator_match’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match);


Please send a followup patch for this.