netdev - Re: [PATCH net] bpf: fix bpf_skb_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160812230640.GA48651@ast-mbp.thefacebook.com>
Date:	Fri, 12 Aug 2016 16:06:42 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	davem@...emloft.net, kafai@...com, tj@...nel.org, sargun@...gun.me,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] bpf: fix bpf_skb_in_cgroup helper naming

On Fri, Aug 12, 2016 at 10:17:17PM +0200, Daniel Borkmann wrote:
> While hashing out BPF's current_task_under_cgroup helper bits, it came
> to discussion that the skb_in_cgroup helper name was suboptimally chosen.
> 
> Tejun says:
> 
>   So, I think in_cgroup should mean that the object is in that
>   particular cgroup while under_cgroup in the subhierarchy of that
>   cgroup. Let's rename the other subhierarchy test to under too. I
>   think that'd be a lot less confusing going forward.
> 
>   [...]
> 
>   It's more intuitive and gives us the room to implement the real
>   "in" test if ever necessary in the future.
> 
> Since this touches uapi bits, we need to change this as long as v4.8
> is not yet officially released. Thus, change the helper enum and rename
> related bits.
> 
> Fixes: 4a482f34afcc ("cgroup: bpf: Add bpf_skb_in_cgroup_proto")
> Reference: http://patchwork.ozlabs.org/patch/658500/
> Suggested-by: Sargun Dhillon <sargun@...gun.me>
> Suggested-by: Tejun Heo <tj@...nel.org>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Acked-by: Alexei Starovoitov <ast@...nel.org>