netdev - Re: [PATCH net] bpf: fix bpf_skb_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160813061402.GA68945@kafai-mba.local>
Date:	Fri, 12 Aug 2016 23:14:02 -0700
From:	Martin KaFai Lau <kafai@...com>
To:	Daniel Borkmann <daniel@...earbox.net>
CC:	<davem@...emloft.net>, <alexei.starovoitov@...il.com>,
	<tj@...nel.org>, <sargun@...gun.me>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net] bpf: fix bpf_skb_in_cgroup helper naming

On Fri, Aug 12, 2016 at 10:17:17PM +0200, Daniel Borkmann wrote:
> While hashing out BPF's current_task_under_cgroup helper bits, it came
> to discussion that the skb_in_cgroup helper name was suboptimally chosen.
>
> Tejun says:
>
>   So, I think in_cgroup should mean that the object is in that
>   particular cgroup while under_cgroup in the subhierarchy of that
>   cgroup. Let's rename the other subhierarchy test to under too. I
>   think that'd be a lot less confusing going forward.
>
>   [...]
>
>   It's more intuitive and gives us the room to implement the real
>   "in" test if ever necessary in the future.
>
> Since this touches uapi bits, we need to change this as long as v4.8
> is not yet officially released. Thus, change the helper enum and rename
> related bits.
Thanks for working on this and be-lated

Acked-by: Martin KaFai Lau <kafai@...com>