lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160813.115222.443333178659469072.davem@davemloft.net> Date: Sat, 13 Aug 2016 11:52:22 -0700 (PDT) From: David Miller <davem@...emloft.net> To: appana.durga.rao@...inx.com Cc: robh+dt@...nel.org, mark.rutland@....com, nicolas.ferre@...el.com, sergio.prado@...abworks.com, gregory.clement@...e-electrons.com, narmstrong@...libre.com, michal.simek@...inx.com, appanad@...inx.com, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: macb: add phy-handle support for the macb From: Kedareswara rao Appana <appana.durga.rao@...inx.com> Date: Sat, 13 Aug 2016 15:31:49 +0530 > @@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) > dev_set_drvdata(&bp->dev->dev, bp->mii_bus); > > np = bp->pdev->dev.of_node; > - if (np) { > + np1 = of_get_parent(bp->phy_node); > + if (np1) { > + of_node_put(np1); > + err = of_mdiobus_register(bp->mii_bus, np1); > + if (err) > + goto err_out_unregister_bus; > + } else if (np) { I don't know about this, all OF nodes other than the root have a parent node which is non-NULL. This parent node can be anything. Just blinding assuming that any parent node of the phy_node is what we are looking for, without any other supplementary checks at all, seems to be asking for trouble at the very least.
Powered by blists - more mailing lists