netdev - Re: [Patch net v3 5/5] net_sched: convert tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 13 Aug 2016 22:03:24 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [Patch net v3 5/5] net_sched: convert tcf_exts from list to
 pointer array

On Sat, Aug 13, 2016 at 4:33 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> Just minor comment below:
>
> On 16-08-11 08:41 PM, Cong Wang wrote:
>
>
>> +static inline void
>> +tcf_exts_to_list(const struct tcf_exts *exts, struct list_head *actions)
>> +{
>
>
> to:
> static inline void tcf_exts_to_list(const struct tcf_exts *exts,
>                                     struct list_head *actions)

I don't disagree, just want to point out that other functions
in this header use similar indention. I am fine with either.

I will change this one, but you probably will need to change
the rest. ;)