netdev - Re: [PATCH net] bpf: fix write helpers with regards to non-linear parts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160813.150138.275492199968284654.davem@davemloft.net>
Date:	Sat, 13 Aug 2016 15:01:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	alexei.starovoitov@...il.com, tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: [PATCH net] bpf: fix write helpers with regards to non-linear
 parts

From: Daniel Borkmann <daniel@...earbox.net>
Date: Thu, 11 Aug 2016 21:38:37 +0200

> Fix the bpf_try_make_writable() helper and all call sites we have in BPF,
> it's currently defect with regards to skbs when the write_len spans into
> non-linear parts, no matter if cloned or not.
 ...
> Fixes: 608cd71a9c7c ("tc: bpf: generalize pedit action")
> Fixes: 91bc4822c3d6 ("tc: bpf: add checksum helpers")
> Fixes: 3697649ff29e ("bpf: try harder on clones when writing into skb")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Acked-by: Alexei Starovoitov <ast@...nel.org>

Applied and queued up for -stable, thanks.