lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160815152250.GE3353@io.lakedaemon.net> Date: Mon, 15 Aug 2016 15:22:50 +0000 From: Jason Cooper <jason@...edaemon.net> To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com> Cc: monstr@...str.eu, ralf@...ux-mips.org, tglx@...utronix.de, marc.zyngier@....com, linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip Hi Zubair, On Mon, Aug 15, 2016 at 02:55:27PM +0100, Zubair Lutfullah Kakakhel wrote: > The Xilinx AXI Interrupt Controller IP block is used by the MIPS > based xilfpga platform. > > Move the interrupt controller code out of arch/microblaze so that > it can be used by everyone > > Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com> > --- > arch/microblaze/Kconfig | 1 + > arch/microblaze/kernel/Makefile | 2 +- > drivers/irqchip/Kconfig | 4 ++++ > drivers/irqchip/Makefile | 1 + > arch/microblaze/kernel/intc.c => drivers/irqchip/irq-xilinx.c | 0 > 5 files changed, 7 insertions(+), 1 deletion(-) > rename arch/microblaze/kernel/intc.c => drivers/irqchip/irq-xilinx.c (100%) When you send the next version, please disable rename detection. The driver looks pretty straight forward, but I'd like to take the opportunity to clean up the abstraction around read and write. As well as making it easier for everyone to review on-list. thx, Jason.
Powered by blists - more mailing lists