lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <DM5PR03MB2538F9629FA09B6E3BE4FC5ECA120@DM5PR03MB2538.namprd03.prod.outlook.com> Date: Mon, 15 Aug 2016 15:54:55 +0000 From: Haiyang Zhang <haiyangz@...rosoft.com> To: Vitaly Kuznetsov <vkuznets@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, KY Srinivasan <kys@...rosoft.com>, Stephen Hemminger <stephen@...workplumber.org> Subject: RE: [PATCH net v2 5/5] hv_netvsc: fix bonding devices check in netvsc_netdev_event() > -----Original Message----- > From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com] > Sent: Monday, August 15, 2016 11:49 AM > To: netdev@...r.kernel.org > Cc: devel@...uxdriverproject.org; linux-kernel@...r.kernel.org; Haiyang > Zhang <haiyangz@...rosoft.com>; KY Srinivasan <kys@...rosoft.com>; > Stephen Hemminger <stephen@...workplumber.org> > Subject: [PATCH net v2 5/5] hv_netvsc: fix bonding devices check in > netvsc_netdev_event() > > Bonding driver sets IFF_BONDING on both master (the bonding device) and > slave (the real NIC) devices and in netvsc_netdev_event() we want to skip > master devices only. Currently, there is an uncertainty when a slave > interface is removed: if bonding module comes first in netdev_chain it > clears IFF_BONDING flag on the netdev and netvsc_netdev_event() > correctly > handles NETDEV_UNREGISTER event, but in case netvsc comes first on the > chain it sees the device with IFF_BONDING still attached and skips it. As > we still hold vf_netdev pointer to the device we crash on the next inject. > > Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com> Thanks! Acked-by: Haiyang Zhang <haiyangz@...rosoft.com>
Powered by blists - more mailing lists