netdev - Re: [PATCH net v3] gre: set inner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Aug 2016 10:02:10 -0700
From:	pravin shelar <pshelar@....org>
To:	Simon Horman <simon.horman@...ronome.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Alexander Duyck <alexander.duyck@...il.com>
Subject: Re: [PATCH net v3] gre: set inner_protocol on xmit

On Mon, Aug 15, 2016 at 4:06 AM, Simon Horman
<simon.horman@...ronome.com> wrote:
> Ensure that the inner_protocol is set on transmit so that GSO segmentation,
> which relies on that field, works correctly.
>
> This is achieved by setting the inner_protocol in gre_build_header rather
> than each caller of that function. It ensures that the inner_protocol is
> set when gre_fb_xmit() is used to transmit GRE which was not previously the
> case.
>
> I have observed this is not the case when OvS transmits GRE using
> lwtunnel metadata (which it always does).
>
> Fixes: 38720352412a ("gre: Use inner_proto to obtain inner header protocol")
> Cc: Pravin Shelar <pshelar@....org>
> Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> ---
> v3
> * Move logic to gre_build_header() as suggested by Pravin Shelar.
>
> v2
> * Added Alexander's Ack
> * Drop RFC designation
> ---

Acked-by: Pravin B Shelar <pshelar@....org>