| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Aug 2016 01:51:22 +0800 From: Sean Wang <sean.wang@...iatek.com> To: <john@...ozen.org>, <davem@...emloft.net> CC: <nbd@...nwrt.org>, <netdev@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>, <keyhaede@...il.com>, Sean Wang <sean.wang@...iatek.com> Subject: [PATCH v2 1/5] net: ethernet: mediatek: add REVMII and fix RMII mode supported by GMAC The patch adds the supplement for the setup of reverse MII (REVMII) on GMAC, fixes up the incorrect setup of reduced MII (RMII) on GMAC and rearranges the error handling for invalid phy argument. Signed-off-by: Sean Wang <sean.wang@...iatek.com> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 88b04dd..f19b8b9 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -245,12 +245,16 @@ static int mtk_phy_connect(struct mtk_mac *mac) case PHY_INTERFACE_MODE_MII: ge_mode = 1; break; - case PHY_INTERFACE_MODE_RMII: + case PHY_INTERFACE_MODE_REVMII: ge_mode = 2; break; + case PHY_INTERFACE_MODE_RMII: + if (!mac->id) + goto err_phy; + ge_mode = 3; + break; default: - dev_err(eth->dev, "invalid phy_mode\n"); - return -1; + goto err_phy; } /* put the gmac into the right mode */ @@ -272,6 +276,11 @@ static int mtk_phy_connect(struct mtk_mac *mac) of_node_put(np); return 0; + +err_phy: + of_node_put(np); + dev_err(eth->dev, "invalid phy_mode\n"); + return -EINVAL; } static int mtk_mdio_init(struct mtk_eth *eth) -- 1.7.9.5
Powered by blists - more mailing lists