netdev - Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57B220C0.3060608@codeaurora.org>
Date:	Mon, 15 Aug 2016 15:06:24 -0500
From:	Timur Tabi <timur@...eaurora.org>
To:	Rob Herring <robh@...nel.org>
Cc:	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, sdharia@...eaurora.org,
	shankerd@...eaurora.org, vikrams@...eaurora.org,
	cov@...eaurora.org, gavidov@...eaurora.org, andrew@...n.ch,
	bjorn.andersson@...aro.org, mlangsdo@...hat.com, jcm@...hat.com,
	agross@...eaurora.org, davem@...emloft.net, f.fainelli@...il.com,
	LinoSanfilippo@....de, "Rafael J. Wysocki" <rjw@...ysocki.net>,
	Al Stone <al.stone@...aro.org>
Subject: Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

+ Rafael and Al, for ACPI help.

Rob Herring wrote:
>> >+Optional properties:
>> >+- phy-version : the version of the integrated emac phy, either 1 or 2.

> Sounds like 2 different h/w. The compatible property should distinguish
> this.

So I implemented this in v8 of my driver, but it is causing problems for 
ACPI.

In ACPI, the equivalent to a compatible string is the HID, which is 
QCOM8070 for the EMAC.  The problem is that it's very difficult, if not 
impossible, to create new HIDs for different versions of the same device.

The driver will primarily (if not exclusively) be used on ACPI 
platforms, not DT.  In Qualcomm, DT is for mobile chips, and ACPI is for 
server.  To my knowledge, there are no plans to use this driver on an 
actual DT-enabled platform, but I want to support DT anyway.

The other problem is that the "internal PHY" of the EMAC is technically 
a separate device, and it's interchangeable.  Future versions of our 
chips will use different internal PHYs, but the EMAC will stay the same.

So I would like a solution that works on DT and ACPI.  I suppose I could 
use compatible strings on DT, and a "phy-version" DSD (property) on 
ACPI.  If that's acceptable to everyone, then I can do that.  It seems 
clunky to me.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.