netdev - [PATCH iproute] ipila: Fixed unitialized variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Aug 2016 16:30:22 -0700
From:	Tom Herbert <tom@...bertland.com>
To:	<stephen@...workplumber.org>, <netdev@...r.kernel.org>
CC:	<kernel-team@...com>, Tom Herbert <tom@...bertland.com>
Subject: [PATCH iproute] ipila: Fixed unitialized variables

Initialize locator and locator_match to zero and only do
addattr if they have been set.

Signed-off-by: Tom Herbert <tom@...bertland.com>
---
 ip/ipila.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/ip/ipila.c b/ip/ipila.c
index c30bdbf..57f8c79 100644
--- a/ip/ipila.c
+++ b/ip/ipila.c
@@ -149,8 +149,8 @@ static int do_list(int argc, char **argv)
 static int ila_parse_opt(int argc, char **argv, struct nlmsghdr *n,
 			 bool adding)
 {
-	__u64 locator;
-	__u64 locator_match;
+	__u64 locator = 0;
+	__u64 locator_match = 0;
 	int ifindex = 0;
 	bool loc_set = false;
 	bool loc_match_set = false;
@@ -202,8 +202,11 @@ static int ila_parse_opt(int argc, char **argv, struct nlmsghdr *n,
 		}
 	}
 
-	addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match);
-	addattr64(n, 1024, ILA_ATTR_LOCATOR, locator);
+	if (loc_match_set)
+		addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match);
+
+	if (loc_set)
+		addattr64(n, 1024, ILA_ATTR_LOCATOR, locator);
 
 	if (ifindex_set)
 		addattr32(n, 1024, ILA_ATTR_IFINDEX, ifindex);
-- 
2.8.0.rc2