netdev - Re: [RFC net-next 0/2] net/sched: cls_flower, act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <faa0a9ab-fc02-543e-c60a-0d22b253a830@mojatatu.com>
Date:	Mon, 15 Aug 2016 06:08:10 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Amir Vadai <amir@...ai.me>, Jiri Pirko <jiri@...nulli.us>
Cc:	Cong Wang <xiyou.wangcong@...il.com>,
	John Fastabend <john.fastabend@...il.com>,
	Jiri Pirko <jiri@...lanox.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Hadar Har-Zion <hadarh@...lanox.com>,
	Oded Shanoon <odeds@...lanox.com>,
	Amir Vadai <amirva@...lanox.com>
Subject: Re: [RFC net-next 0/2] net/sched: cls_flower, act_mirred: VXLAN
 redirect using TC

On 16-08-15 05:08 AM, Amir Vadai wrote:
> On Mon, Aug 15, 2016 at 11:17:40AM +0300, Amir Vadai wrote:
>> On Mon, Aug 15, 2016 at 09:11:22AM +0200, Jiri Pirko wrote:
>>> Sun, Aug 14, 2016 at 07:53:30PM CEST, xiyou.wangcong@...il.com wrote:

>>
>> Thanks,
>> Amir
>
> Any objection to the following?
>
> # ENCAP rule
> tc filter add dev $ETH protocol ip parent ffff: prio 10 \
> 		flower ip_proto 1 \
> 		action set_tunnel_key src_ip 11.11.0.1 dst_ip 11.11.0.2 key_id 11 dst_port 4789 \
> 		action mirred egress redirect dev $VXLAN

Assuming $VXLAN is actually not a linux netdev of type vxlan?
then the action does vxlan encap redirect sends it to the $VXLAN
dev with encapsulation in place.
Sounds to me like a name like "vxlan" would be more usable. Example:

tc filter add dev $ETH protocol ip parent ffff: prio 10 ..
action vxlan encap src_ip 11.11.0.1 dst_ip 11.11.0.2 key_id 11 ....
action mirred egress redirect dev eth0

>
> # DECAP rule
> tc filter add dev $VXLAN protocol ip parent ffff: prio 10 \
> 		flower \
> 			enc_src_ip 11.11.0.2 enc_dst_ip 11.11.0.1 enc_key_id 11 \
> 			ip_proto 1 \
> 		action mirred egress redirect dev $ETH
>

And a decap would be of the form:
tc filter add dev $ETH protocol ip parent ffff: prio 10 ..
action vxlan decap

i.e there is no redirect needed here, no?

cheers,
jamal