lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1471265717-10784-1-git-send-email-colin.king@canonical.com> Date: Mon, 15 Aug 2016 13:55:17 +0100 From: Colin King <colin.king@...onical.com> To: Yisen Zhuang <yisen.zhuang@...wei.com>, Salil Mehta <salil.mehta@...wei.com>, "David S . Miller" <davem@...emloft.net>, Kejian Yan <yankejian@...wei.com>, Daode Huang <huangdaode@...ilicon.com>, lipeng <lipeng321@...wei.com>, Lisheng <lisheng011@...wei.com>, netdev@...r.kernel.org Cc: linux-kernel@...r.kernel.org Subject: [PATCH] net: hns: mdio->irq is an array, so no need to check if it is null From: Colin Ian King <colin.king@...onical.com> The null check on mdio->irq is redundant since mdio->irq is an array of PHY_MAX_ADDR ints and hence can never be null. Remove the redundant check. Signed-off-by: Colin Ian King <colin.king@...onical.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c index 5c8afe1..a834774 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c @@ -684,8 +684,7 @@ hns_mac_register_phydev(struct mii_bus *mdio, struct hns_mac_cb *mac_cb, if (!phy || IS_ERR(phy)) return -EIO; - if (mdio->irq) - phy->irq = mdio->irq[addr]; + phy->irq = mdio->irq[addr]; /* All data is now stored in the phy struct; * register it -- 2.8.1
Powered by blists - more mailing lists