netdev - Re: [PATCH v2 0/3] VSOCK: vsockmon virtual device to monitor AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160815151326.GE3598@stefanha-x1.localdomain>
Date:	Mon, 15 Aug 2016 16:13:26 +0100
From:	Stefan Hajnoczi <stefanha@...hat.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	ggarcia@...a.uab.cat, netdev@...r.kernel.org
Subject: Re: [PATCH v2 0/3] VSOCK: vsockmon virtual device to monitor
 AF_VSOCK sockets.

On Mon, Aug 15, 2016 at 02:15:38AM +0300, Michael S. Tsirkin wrote:
> On Sat, Aug 13, 2016 at 12:21:51PM +0200, ggarcia@...a.uab.cat wrote:
> > From: Gerard Garcia <ggarcia@...c.uab.cat>
> > 
> > This patch applies over the mst vhost git repository:
> > http://git.kernel.org/cgit/linux/kernel/git/mst/vhost.git
> 
> So I do like where this is going, but it gives me pause
> that there's a global list of taps, where all sockets
> seem to multicast to them all.
> 
> In particular, this won't play well with things
> like containers.

vsock currently has no network namespace support.  I agree that the tap
instances should be per-namespace when we add namespace support.

> As each socket is bound to a physical device, how about binding
> the monitor there as well?

Sockets aren't bound to physical devices, they are bound globally in the
af_vsock.ko module.  The module currently doesn't allow multiple
instances (you cannot have multiple VMCI or virtio transports).

> Only sockets from this device
> would do the forwarding, and only one monitor per
> device would be supported.
> 
> In a sense this will make it more like macvtap than tap.

Restricting the number of monitors could make userspace cumbersome.
Imagine two scripts that want to capture packets.  The two scripts have
no knowledge of each other and create their own vsockmon interfaces.  If
we restrict vsockmon to just 1 interface then users need to agree on
sharing just 1 vsockmon interface.  I don't think this is beneficial.

So I think this global list is acceptable until we introduce network
namespace support.  At that point it will become per-namespace.

Stefan

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)