netdev - Re: [PATCH RFCv2] net: ethernet: macb: Add support for rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKfKVtHMB4mHJMOnfLaGiArCJJ9VQ9-gCbLPXj1COO9L8adi5g@mail.gmail.com>
Date:	Tue, 16 Aug 2016 10:16:50 +0530
From:	Shubhrajyoti Datta <shubhrajyoti.datta@...il.com>
To:	Rob Herring <robh@...nel.org>
Cc:	Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Michal Simek <michal.simek@...inx.com>
Subject: Re: [PATCH RFCv2] net: ethernet: macb: Add support for rx_clk

Hi Rob,
Thanks for the review.

On Sat, Aug 13, 2016 at 12:33 AM, Rob Herring <robh@...nel.org> wrote:
> On Fri, Aug 12, 2016 at 03:46:19PM +0530, Shubhrajyoti Datta wrote:
>> Some of the platforms like zynqmp ultrascale+ has a
>> separate clock gate for the rx clock. Add an optional
>> rx_clk so that the clock can be enabled.
>>
>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
>> ---
>> v2:
>> fix warning
>>
>>  Documentation/devicetree/bindings/net/macb.txt |  2 +-
>>  drivers/net/ethernet/cadence/macb.c            | 31 +++++++++++++++++++++-----
>>  drivers/net/ethernet/cadence/macb.h            |  4 +++-
>>  3 files changed, 30 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
>> index b5a42df..315beda 100644
>> --- a/Documentation/devicetree/bindings/net/macb.txt
>> +++ b/Documentation/devicetree/bindings/net/macb.txt
>> @@ -20,7 +20,7 @@ Required properties:
>>  - phy-mode: See ethernet.txt file in the same directory.
>>  - clock-names: Tuple listing input clock names.
>>       Required elements: 'pclk', 'hclk'
>> -     Optional elements: 'tx_clk'
>> +     Optional elements: 'tx_clk', 'rx_clk'
>
> Please state which compatibles this applies to.

will fix in the next version

>
>>  - clocks: Phandles to input clocks.
>>
>>  Optional properties for PHY child node: