netdev - Re: Microsemi VSC 8531/41 PHY Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160816194132.GA2951@lunn.ch>
Date:	Tue, 16 Aug 2016 21:41:32 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Nagaraju Lakkaraju <Raju.Lakkaraju@...rosemi.com>
Cc:	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Allan Nielsen <Allan.Nielsen@...rosemi.com>
Subject: Re: Microsemi VSC 8531/41 PHY Driver

On Fri, Aug 05, 2016 at 05:54:21PM +0530, Nagaraju Lakkaraju wrote:
> Hello,
> 
> I added all review comments and re-sending for review.
> 
> >From a5017f5878a92d2acec86a6a29b1498c457cb73a Mon Sep 17 00:00:00 2001
> From: Nagaraju Lakkaraju <Raju.Lakkaraju@...rosemi.com>
> Date: Wed, 3 Aug 2016 18:28:24 +0530
> Subject: [PATCH v2] net: phy: Add drivers for Microsemi PHYs

Please use git send-email to send patches.

All comments which should not be committed to the change log should
appear after the ---. It is normal to briefly list changes between
this version and the previous version.

> +static int vsc85xx_phy_page_set(struct phy_device *phydev, u8 page)
> +{
> +       int rc;
> +
> +       rc = phy_write(phydev, MSCC_EXT_PAGE_ACCESS, page);
> +       return rc;

Please remove rc and just do

	return phy_write(phydev, MSCC_EXT_PAGE_ACCESS, page);

> +}
> +
> +static int vsc85xx_default_config(struct phy_device *phydev)

This function is setting the RGMII delay. So vsc85xx_default_config()
is not a particularly good name.

   Andrew