netdev - RE: [Patch net v3 5/5] net_sched: convert tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB00DFFCA@AcuExch.aculab.com>
Date:	Tue, 16 Aug 2016 12:54:52 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Jamal Hadi Salim' <jhs@...atatu.com>,
	Cong Wang <xiyou.wangcong@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Patch net v3 5/5] net_sched: convert tcf_exts from list to
 pointer array

From: Jamal Hadi Salim
> Sent: 13 August 2016 12:34
> 
> Just minor comment below:
> 
> On 16-08-11 08:41 PM, Cong Wang wrote:
> 
> 
> > +static inline void
> > +tcf_exts_to_list(const struct tcf_exts *exts, struct list_head *actions)
> > +{
> 
> to:
> static inline void tcf_exts_to_list(const struct tcf_exts *exts,
>                                      struct list_head *actions)

It may not be the 'Linux style' but I much prefer the former since it
makes 'grep -r '^tcf_exts_to_list\>' find the definition.

	David