[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <57B4F0CC.9020102@gmail.com>
Date: Wed, 17 Aug 2016 16:18:36 -0700
From: John Fastabend <john.fastabend@...il.com>
To: Eric Dumazet <eric.dumazet@...il.com>
Cc: xiyou.wangcong@...il.com, jhs@...atatu.com,
alexei.starovoitov@...il.com, brouer@...hat.com,
john.r.fastabend@...el.com, netdev@...r.kernel.org,
davem@...emloft.net
Subject: Re: [RFC PATCH 12/13] net: sched: add support for TCQ_F_NOLOCK
subqueues to sch_mq
On 16-08-17 04:04 PM, Eric Dumazet wrote:
> On Wed, 2016-08-17 at 12:38 -0700, John Fastabend wrote:
>> The sch_mq qdisc creates a sub-qdisc per tx queue which are then
>> called independently for enqueue and dequeue operations. However
>> statistics are aggregated and pushed up to the "master" qdisc.
>>
>> This patch adds support for any of the sub-qdiscs to be per cpu
>> statistic qdiscs. To handle this case add a check when calculating
>> stats and aggregate the per cpu stats if needed.
>>
>> Also exports __gnet_stats_copy_queue() to use as a helper function.
>
>
> Looks like this patch should be happening earlier in the series ?
>
>
hmm yep patches 12 and 13 should come before 11 to avoid introducing
a bug and subsequently fixing them.
Powered by blists - more mailing lists