netdev - Re: [PATCH net-next 0/3] Fix mv88e6xxx wait function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877fbdiuo5.fsf@ketchup.mtl.sfl>
Date:   Thu, 18 Aug 2016 18:22:50 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next 0/3] Fix mv88e6xxx wait function

Andrew Lunn <andrew@...n.ch> writes:

> The mv88e6xxx wait function can be upset of the system has nots of
> other things to do and a sleep takes a lot longer than expected. Fix
> this be using a fixed number of iterations, rather than a fixed
> walkclock time.
>
> Witht that change made, it is possible to consoliate another
> wait function.
>
> A wait actually timing out should not happen and when it does, it
> means something serious is wrong. Make sure an error is logged,
> since not all callers will log an error.
>
> Andrew Lunn (3):
>   dsa: mv88e6xxx: Timeout based on iterations, not time
>   dsa: mv88e6xxx: Use mv88e6xx_wait in mv88e6xxx_update()
>   dsa: mv88e6xxx: Make mv88e6xxx_wait() timeout verbose
>
>  drivers/net/dsa/mv88e6xxx/chip.c | 32 +++++++++++---------------------
>  1 file changed, 11 insertions(+), 21 deletions(-)

Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

David, this series superseeds http://patchwork.ozlabs.org/patch/660270/.

Thanks,

        Vivien