netdev - Re: [PATCH net-next] dsa: mv88e6xxx: Timeout based on iterations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160818183946.GD13458@lunn.ch>
Date:   Thu, 18 Aug 2016 20:39:46 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:     David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] dsa: mv88e6xxx: Timeout based on iterations

> >  static int mv88e6xxx_wait(struct mv88e6xxx_chip *chip, int addr, int reg,
> >  			  u16 mask)
> >  {
> > -	unsigned long timeout = jiffies + HZ / 10;
> > +	int i;
> >  
> > -	while (time_before(jiffies, timeout)) {
> > +	for (i = 0; i < 16; i++) {
> >  		u16 val;
> >  		int err;
> >  
> 
> Since we remove the elapsed time here, can we use mv88e6xxx_wait in
> mv88e6xxx_update? It'd be good to have a consistent wait routine
> everywhere.

Hi Vivien

Yes, it looks like that should work. I will add a second patch to do
this.

	Andrew