lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Aug 2016 13:37:05 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: netdev@...r.kernel.org, Amitoj Kaur Chawla <amitoj1606@...il.com>, "David S. Miller" <davem@...emloft.net>, Felipe Balbi <felipe.balbi@...ux.intel.com>, Florian Westphal <fw@...len.de> Cc: kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: wan-lmc: Improving source code formatting Hello, The Coccinelle software pointed out that the function "lmc_ioctl" is an update candidate according to the message "opportunity for memdup_user". https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wan/lmc/lmc_main.c?id=6040e57658eee6eb1315a26119101ca832d1f854#n486 I guess that it would be nice to improve also this implementation. But there are further constraints to consider. The script "checkpatch.pl" can point information out like the following. * ERROR: code indent should use tabs where possible * WARNING: please, no spaces at the start of a line The source files for this software module contain also some open issues for the preferred source code formatting. * How should these places be fixed so that they will match the current Linux coding style before additional adjustments can be safely tried? * Would you like to suggest any advanced tools (besides "scripts/cleanfile") for a corresponding source code beautification? Which pretty-printing approaches are acceptable for Linux so far? Regards, Markus
Powered by blists - more mailing lists