netdev - Re: [Patch net-next] net_sched: properly handle failure case of tcf_exts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <802eede6-be83-133b-5413-d9d26a317419@mojatatu.com>
Date:   Mon, 22 Aug 2016 14:12:04 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [Patch net-next] net_sched: properly handle failure case of
 tcf_exts_init()

On 16-08-22 01:40 PM, Cong Wang wrote:
> On Mon, Aug 22, 2016 at 5:11 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
>>
>>
>> Answered my own question by looking at implementation of kfree();
>> ignores NULL (unlike free())
>
> Seriously?
>
> Here is what C standard says about free():
>

I may be confusing it with fact that the kernel kfree() used to not
check for nullness or perhaps a _lot_ of people used to check for the
null pointer before calling kfree().
[At some point a massive patch must have gone in and cleaned that kind
of code up because i cant find evidence of what i am saying ;->]

cheers,
jamal