netdev - Re: [PATCH] xfrm: Only add l3mdev oif to dst lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160822071634.GD3735@gauss.secunet.com>
Date:   Mon, 22 Aug 2016 09:16:35 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     David Miller <davem@...emloft.net>
CC:     <dsa@...ulusnetworks.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] xfrm: Only add l3mdev oif to dst lookups

On Wed, Aug 17, 2016 at 07:31:14PM -0400, David Miller wrote:
> From: David Ahern <dsa@...ulusnetworks.com>
> Date: Sun, 14 Aug 2016 19:52:56 -0700
> 
> > Subash reported that commit 42a7b32b73d6 ("xfrm: Add oif to dst lookups")
> > broke a wifi use case that uses fib rules and xfrms. The intent of
> > 42a7b32b73d6 was driven by VRFs with IPsec. As a compromise relax the
> > use of oif in xfrm lookups to L3 master devices only (ie., oif is either
> > an L3 master device or is enslaved to a master device).
> > 
> > Fixes: 42a7b32b73d6 ("xfrm: Add oif to dst lookups")
> > Reported-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
> > Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
> 
> Steffen, please pick this up.

Now applied to the ipsec tree, thanks a lot!