netdev - Re: [PATCH net 1/1] net sched ife action: fix encoding to use real length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <592c8a26-ff5d-388c-e49b-2e10394e7e50@mojatatu.com>
Date:   Mon, 22 Aug 2016 07:00:54 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, daniel@...earbox.net,
        xiyou.wangcong@...il.com, mrv@...atatu.com
Subject: Re: [PATCH net 1/1] net sched ife action: fix encoding to use real
 length

On 16-08-19 09:22 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 8/19/2016 1:17 PM, Jamal Hadi Salim wrote:
>
>> From: Jamal Hadi Salim <jhs@...atatu.com>
>>
>> Encoding of the metadata was using the padded length as opposed to
>> the real length of the data which is a bug per specification.
>> This has not been an issue todate because all metadatum specified
>
>    To date? Metadata perhaps?
>

Todate as in "up to today".

>> so far has been 32 bit where aligned and data length are the same width.
>> This also includes a bug fix for validating the length of a u16 field.
>> But since there is no metadata of size u16 yes we are fine to include it
>> here.
>>
>> While at it get rid of magic numbers
>>
>> Fixes: ef6980b6
>
>    This tag has a standardized format, including 12-digit SHA1 and the
> commit summary enclosed in ("").
>

Ok, let me fix that and resend.

cheers,
jamal