netdev - Re: [Patch net-next] net_sched: properly handle failure case of tcf_exts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09b957e2-5a37-643d-9cc1-2bbddc4ad8b4@mojatatu.com>
Date:   Mon, 22 Aug 2016 08:11:03 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Subject: Re: [Patch net-next] net_sched: properly handle failure case of
 tcf_exts_init()

On 16-08-19 03:36 PM, Cong Wang wrote:
> After commit 22dc13c837c3 ("net_sched: convert tcf_exts from list to pointer array")
> we do dynamic allocation in tcf_exts_init(), therefore we need
> to handle the ENOMEM case properly.
>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Answered my own question by looking at implementation of kfree();
ignores NULL (unlike free())

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal