netdev - Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

Open Source and information security mailing list archives

Message-ID: <20160823151619.GK20029@lunn.ch>
Date:   Tue, 23 Aug 2016 17:16:19 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     f.fainelli@...il.com, michal.simek@...inx.com,
        soren.brinkmann@...inx.com, netdev@...r.kernel.org,
        Wei Yongjun <weiyongjun1@...wei.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol
 warning

On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>

Hi Wei

No need for the additional From:

git am will use the one in the mail header as the author of the patch,
and it is in the signed-off-by as well.

Thanks
    Andrew

> Fixes the following sparse warning:
> 
> drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
>  symbol 'xgmiitorgmii_probe' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
> index e7a20ec..2e408b8 100644
> --- a/drivers/net/phy/xilinx_gmii2rgmii.c
> +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
> @@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
>  	return 0;
>  }
>  
> -int xgmiitorgmii_probe(struct mdio_device *mdiodev)
> +static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
>  {
>  	struct device *dev = &mdiodev->dev;
>  	struct device_node *np = dev->of_node, *phy_node;
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives