netdev - Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANdmM3O1BEZpwE_b9m1a_rOtz_LQLN=FRxhk7bcDOkECOjDeSA@mail.gmail.com>
Date:   Tue, 23 Aug 2016 22:10:34 +0530
From:   Kedari Appana <kedare06@...il.com>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>, michal.simek@...inx.com,
        soren.brinkmann@...inx.com, Wei Yongjun <weiyongjun1@...wei.com>,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

HI,

        Thanks for the patch..

On Tue, Aug 23, 2016 at 8:36 PM, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
>  symbol 'xgmiitorgmii_probe' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Acked by: Kedareswara rao Appana <appanad@...inx.com>

> ---
>  drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
> index e7a20ec..2e408b8 100644
> --- a/drivers/net/phy/xilinx_gmii2rgmii.c
> +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
> @@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
>         return 0;
>  }
>
> -int xgmiitorgmii_probe(struct mdio_device *mdiodev)
> +static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
>  {
>         struct device *dev = &mdiodev->dev;
>         struct device_node *np = dev->of_node, *phy_node;
>