netdev - Re: [PATCH v3 net-next] net: diag: support SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1471974878.14381.31.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 23 Aug 2016 10:54:38 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Lorenzo Colitti <lorenzo@...gle.com>
Cc:     David Ahern <dsa@...ulusnetworks.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net-next] net: diag: support SOCK_DESTROY for UDP
 sockets

On Wed, 2016-08-24 at 02:24 +0900, Lorenzo Colitti wrote:
> On Wed, Aug 24, 2016 at 2:16 AM, David Ahern <dsa@...ulusnetworks.com> wrote:
> >> So you'd remove the sock_put and sock_gen_put calls from tcp_abort and
> >> just add one sock_gen_put in tcp_diag_destroy? That does seem simpler.
> >
> > untested and mangled on a copy and paste but the intent is:
> ...
> >         if (IS_ERR(sk))
> >                 return PTR_ERR(sk);
> >
> > -       return sock_diag_destroy(sk, ECONNABORTED);
> > +       err = sock_diag_destroy(sk, ECONNABORTED);
> > +
> > +       sock_gen_put(sk);     <---- if (!sk_fullsock(sk)) needed here? seems like this works for all TCP
> 
> That does seem nicer. I think sock_gen_put will work on all types of
> TCP sockets, so sk_fullsock is not needed here.
> 
> Eric, any thoughts?

LGTM, and if (!sk_fullsock(sk)) is not needed.