netdev - Re: [PATCH v2 net 1/1] net sched: fix encoding to use real length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160822.210211.926745178893055522.davem@davemloft.net>
Date:   Mon, 22 Aug 2016 21:02:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jhs@...atatu.com
Cc:     netdev@...r.kernel.org, daniel@...earbox.net,
        xiyou.wangcong@...il.com
Subject: Re: [PATCH v2 net 1/1] net sched: fix encoding to use real length

From: Jamal Hadi Salim <jhs@...atatu.com>
Date: Mon, 22 Aug 2016 07:10:20 -0400

> From: Jamal Hadi Salim <jhs@...atatu.com>
> 
> Encoding of the metadata was using the padded length as opposed to
> the real length of the data which is a bug per specification.
> This has not been an issue todate because all metadatum specified
> so far has been 32 bit where aligned and data length are the same width.
> This also includes a bug fix for validating the length of a u16 field.
> But since there is no metadata of size u16 yes we are fine to include it
> here.
> 
> While at it get rid of magic numbers.
> 
> Fixes: ef6980b6becb ("net sched: introduce IFE action")
> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>

Applied.