netdev - Re: [PATCH net] udp: fix poll() issue with zero sized packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1471985794.14381.50.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 23 Aug 2016 13:56:34 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Laura Abbott <labbott@...hat.com>
Cc:     David Miller <davem@...emloft.net>, samanthakumar@...gle.com,
        willemb@...gle.com, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] udp: fix poll() issue with zero sized packets

On Tue, 2016-08-23 at 13:53 -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
...

> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index e61f7cd65d08..2a2ac9e0c985 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -1184,11 +1184,11 @@ out:
>   *	Drops all bad checksum frames, until a valid one is found.
>   *	Returns the length of found skb, or 0 if none is found.
>   */
> -static unsigned int first_packet_length(struct sock *sk)
> +static int first_packet_length(struct sock *sk)


I'll send a V2, updating the comment to :

Returns the length of found skb, or -1 if none is found.

(Thanks Willem for noticing this)