netdev - Re: [net-next PATCH 03/15] net: sched: remove remaining uses for qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1471986645.14381.57.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 23 Aug 2016 14:10:45 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     jhs@...atatu.com, davem@...emloft.net, brouer@...hat.com,
        xiyou.wangcong@...il.com, alexei.starovoitov@...il.com,
        john.r.fastabend@...el.com, netdev@...r.kernel.org
Subject: Re: [net-next PATCH 03/15] net: sched: remove remaining uses for
 qdisc_qlen in xmit path

On Tue, 2016-08-23 at 13:23 -0700, John Fastabend wrote:
> sch_direct_xmit() uses qdisc_qlen as a return value but all call sites
> of the routine only check if it is zero or not. Simplify the logic so
> that we don't need to return an actual queue length value.
> 
> This introduces a case now where sch_direct_xmit would have returned
> a qlen of zero but now it returns true. However in this case all
> call sites of sch_direct_xmit will implement a dequeue() and get
> a null skb and abort. This trades tracking qlen in the hotpath for
> an extra dequeue operation. Overall this seems to be good for
> performance.
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>