netdev - Re: [PATCH net] tun: fix transmit timestamp support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1471994102.14381.60.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 23 Aug 2016 16:15:02 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Soheil Hassas Yeganeh <soheil.kdev@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH net] tun: fix transmit timestamp support

On Tue, 2016-08-23 at 18:22 -0400, Soheil Hassas Yeganeh wrote:
> From: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> Instead of using sock_tx_timestamp, use skb_tx_timestamp to record
> software transmit timestamp of a packet.
> 
> sock_tx_timestamp resets and overrides the tx_flags of the skb.
> The function is intended to be called from within the protocol
> layer when creating the skb, not from a device driver. This is
> inconsistent with other drivers and will cause issues for TCP.
> 

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks !