netdev - Re: [PATCH net-next] alx: add tso support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160823.162424.1499120284925620302.davem@davemloft.net>
Date:   Tue, 23 Aug 2016 16:24:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tobias.regnery@...il.com
Cc:     netdev@...r.kernel.org, jcliburn@...il.com, chris.snook@...il.com
Subject: Re: [PATCH net-next] alx: add tso support

From: Tobias Regnery <tobias.regnery@...il.com>
Date: Tue, 23 Aug 2016 22:21:21 +0200

> @@ -993,6 +993,18 @@ static void alx_reset(struct work_struct *work)
>  	rtnl_unlock();
>  }
>  
> +static inline int alx_tpd_req(struct sk_buff *skb)
> +{

Please don't use inline for functions in foo.c files, let the compiler
decide.

Thanks.