netdev - Re: [PATCH v2 net] udp: fix poll() issue with zero sized packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160823.163941.1551130952096100509.davem@davemloft.net>
Date:   Tue, 23 Aug 2016 16:39:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     labbott@...hat.com, samanthakumar@...gle.com, willemb@...gle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] udp: fix poll() issue with zero sized packets

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 23 Aug 2016 13:59:33 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Laura tracked poll() [and friends] regression caused by commit
> e6afc8ace6dd ("udp: remove headers from UDP packets before queueing")
> 
> udp_poll() needs to know if there is a valid packet in receive queue,
> even if its payload length is 0.
> 
> Change first_packet_length() to return an signed int, and use -1
> as the indication of an empty queue.
> 
> Fixes: e6afc8ace6dd ("udp: remove headers from UDP packets before queueing")
> Reported-by: Laura Abbott <labbott@...hat.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Tested-by: Laura Abbott <labbott@...hat.com>
> ---
> v2: fix the comment/doc (Willem)

Applied and queued up for -stable, thanks.