netdev - Re: [PATCH v2] gianfar: prevent fragmentation in DSA environments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160823.164920.891958713604067093.davem@davemloft.net>
Date:   Tue, 23 Aug 2016 16:49:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zefir.kurtisi@...atec.com
Cc:     netdev@...r.kernel.org, claudiu.manoil@...escale.com,
        andrew@...n.ch
Subject: Re: [PATCH v2] gianfar: prevent fragmentation in DSA environments

From: Zefir Kurtisi <zefir.kurtisi@...atec.com>
Date: Mon, 22 Aug 2016 15:56:38 +0200

> The eTSEC register MRBLR defines the maximum space in
> the RX buffers and is set to 1536 by gianfar. This
> reasonably covers the common use case where the MTU
> is kept at default 1500. In that case, the largest
> Ethernet frame size of 1518 plus an optional
> GMAC_FCB_LEN of 8, and an additional padding of 8
> to handle FSL_GIANFAR_DEV_HAS_TIMER totals to 1534
> and nicely fit within the chosen MRBLR.
> 
> Alas, if the eTSEC is attached to a DSA enabled switch,
> the (E)DSA header extension (4 or 8 bytes) causes every
> maximum sized frame to be fragmented by the hardware.
> 
> This patch increases the maximum RX buffer size by 8
> and rounds up to the next multiple of 64, which the
> hardware's defines as RX buffer granularity.
> 
> Signed-off-by: Zefir Kurtisi <zefir.kurtisi@...atec.com>

Applied.