netdev - Re: [PATCH iproute2 0/4] improve initialization of genl handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160823091801.GG8820@orbyte.nwl.cc>
Date:   Tue, 23 Aug 2016 11:18:01 +0200
From:   Phil Sutter <phil@....cc>
To:     Sabrina Dubroca <sd@...asysnail.net>
Cc:     netdev@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2 0/4] improve initialization of genl handle

On Tue, Aug 16, 2016 at 04:26:54PM +0200, Sabrina Dubroca wrote:
> This patchset fixes several issues for users of genetlink:
> 
>  - Duplicated code for initialization of a genl handle.
>    All users of genl must open a socket and resolve the family, and
>    use the same code to do that.
>    Solution: add a library function.
> 
>  - genl family resolution fails when the module that handles this
>    family is not loaded yet.
>    This means that if we try to initialize the genl handle early in
>    handling the command, we cannot display usage, because we fail hard
>    when trying to resolve the genl family.
>    Solution: move the genl handle initialization after handling the
>    `ip * help` case.
> 
> Sabrina Dubroca (4):
>   libgenl: introduce genl_init_handle
>   macsec: show usage even if the module is not available
>   fou: show usage even if the module is not available
>   ila: show usage even if the module is not available
> 
>  include/libgenl.h |  2 ++
>  ip/ipfou.c        | 20 ++++++--------------
>  ip/ipila.c        | 19 ++++++-------------
>  ip/ipl2tp.c       | 12 ++----------
>  ip/ipmacsec.c     | 20 +++-----------------
>  ip/tcp_metrics.c  | 14 +++-----------
>  lib/libgenl.c     | 17 +++++++++++++++++
>  7 files changed, 39 insertions(+), 65 deletions(-)

Series:
Acked-by: Phil Sutter <phil@....cc>