netdev - Re: [REGRESSION] Select hang with zero sized UDP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160824144246.5a61254c@lxorguk.ukuu.org.uk>
Date:   Wed, 24 Aug 2016 14:42:46 +0100
From:   One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:     "Dan Akunis" <dan.akunis@...il.com>
Cc:     <labbott@...hat.com>, "David Miller" <davem@...emloft.net>,
        <kuznet@....inr.ac.ru>, <jmorris@...ei.org>,
        <yoshfuji@...ux-ipv6.org>, <kaber@...sh.net>,
        <samanthakumar@...gle.com>, <willemb@...gle.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [REGRESSION] Select hang with zero sized UDP packets

On Wed, 24 Aug 2016 11:22:09 +0300
"Dan Akunis" <dan.akunis@...il.com> wrote:

> When select wakes up on a UDP socket, user is expecting to get data. Getting 
> 0 from recvfrom() or whatever read function she uses, is a wrong attitude.
> I agree with David.
> 
> The unit test that expects select to wake up is wrong and should be changed.

The unit test is correct.

The behaviour of a 0 byte frame is actually well established and a 0 byte
data frame is a meaningful message is several protocols. It is distinct
from no pending data because that would report EWOULDBLOCK. It's more fun
with regard to EOF but UDP has no EOF semantics. If you want to
understand how to handle zero length datagrams in a connection oriented
protocol the old DECnet documentation covers it in all its pain 8)

Alan