netdev - Re: [PATCH net-next] tcp: md5: increment sk_drops on syn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQy=z8rU1v2jzO58Gk53GzB5_K09dHoP=viQkhMhYAOZhVQ@mail.gmail.com>
Date:   Wed, 24 Aug 2016 11:53:53 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Yuchung Cheng <ycheng@...gle.com>,
        Julien Goodwin <julieng@...gle.com>
Subject: Re: [PATCH net-next] tcp: md5: increment sk_drops on syn_recv state

On Wed, Aug 24, 2016 at 11:50 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
>
> TCP MD5 mismatches do increment sk_drops counter in all states but
> SYN_RECV.
>
> This is very unlikely to happen in the real world, but worth adding
> to help diagnostics.
>
> We increase the parent (listener) sk_drops.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---

Acked-by: Neal Cardwell <ncardwell@...gle.com>

Thanks, Eric!

neal