netdev - Re: [PATCH] net: macb: Increase DMA buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cccfc176-df56-4add-e6c8-e040f9da31dc@atmel.com>
Date:   Wed, 24 Aug 2016 21:17:04 +0200
From:   Nicolas Ferre <nicolas.ferre@...el.com>
To:     Xander Huff <xander.huff@...com>
CC:     <netdev@...r.kernel.org>, Nathan Sullivan <nathan.sullivan@...com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: macb: Increase DMA buffer size

Le 24/08/2016 à 20:25, Xander Huff a écrit :
> From: Nathan Sullivan <nathan.sullivan@...com>
> 
> In recent testing with the RT patchset, we have seen cases where the
> transmit ring can fill even with up to 200 txbds in the ring.  Increase
> the size of the DMA rings to avoid overruns.
> 
> Signed-off-by: Nathan Sullivan <nathan.sullivan@...com>
> Acked-by: Ben Shelton <ben.shelton@...com>
> Acked-by: Jaeden Amero <jaeden.amero@...com>
> Natinst-ReviewBoard-ID: 83662
> ---
>  drivers/net/ethernet/cadence/macb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 3256839..86a8e20 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -35,12 +35,12 @@
>  
>  #include "macb.h"
>  
> -#define MACB_RX_BUFFER_SIZE	128
> +#define MACB_RX_BUFFER_SIZE	1536

This change seems not covered by the commit message. Can you  please
separate the changes in 2 patches or elaborate a bit more the reason for
this RX buffer size change.

Bye,

>  #define RX_BUFFER_MULTIPLE	64  /* bytes */
>  #define RX_RING_SIZE		512 /* must be power of 2 */
>  #define RX_RING_BYTES		(sizeof(struct macb_dma_desc) * RX_RING_SIZE)
>  
> -#define TX_RING_SIZE		128 /* must be power of 2 */
> +#define TX_RING_SIZE		512 /* must be power of 2 */
>  #define TX_RING_BYTES		(sizeof(struct macb_dma_desc) * TX_RING_SIZE)
>  
>  /* level of occupied TX descriptors under which we wake up TX process */
> 


-- 
Nicolas Ferre