netdev - Re: [PATCH] net: diag: Fix refcnt leak in error path destroying socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160823.231240.868460090939408317.davem@davemloft.net>
Date:   Tue, 23 Aug 2016 23:12:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsa@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, lorenzo@...gle.com, eric.dumazet@...il.com
Subject: Re: [PATCH] net: diag: Fix refcnt leak in error path destroying
 socket

From: David Ahern <dsa@...ulusnetworks.com>
Date: Tue, 23 Aug 2016 21:05:27 -0700

> inet_diag_find_one_icsk takes a reference to a socket that is not
> released if sock_diag_destroy returns an error. Fix by changing
> tcp_diag_destroy to manage the refcnt for all cases and remove
> the sock_put calls from tcp_abort.
> 
> Fixes: c1e64e298b8ca ("net: diag: Support destroying TCP sockets")
> Reported-by: Lorenzo Colitti <lorenzo@...gle.com>
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>

Applied and queued up for -stable.