netdev - Re: [PATCH net-next] cxgb4: Fix issue while re-registering VF mgmt netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160823.170829.2283755198663202650.davem@davemloft.net>
Date:   Tue, 23 Aug 2016 17:08:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hariprasad@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsioc.com
Subject: Re: [PATCH net-next] cxgb4: Fix issue while re-registering VF mgmt
 netdev

From: Hariprasad Shenai <hariprasad@...lsio.com>
Date: Tue, 23 Aug 2016 11:35:32 +0530

> When we disable SRIOV, we used to unregister the netdev but wasn't
> freed. But next time when the same netdev is registered, since the state
> was in 'NETREG_UNREGISTERED', we used to hit BUG_ON in register_netdevice,
> where it expects the state to be 'NETREG_UNINITIALIZED'.
> 
> Alloc netdev and register them while configuring SRIOV, and free them
> when SRIOV is disabled. Also added a new function to setup ethernet
> properties instead of using ether_setup. Set carrier off by default,
> since we don't have to do any transmit on the interface.
> 
> Fixes: 7829451c695e ("cxgb4: Add control net_device for configuring PCIe VF")
> 
> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>

Applied.