netdev - Re: [PATCH v3] net: lpc_eth: Check clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160823.171206.848726795793109531.davem@davemloft.net>
Date:   Tue, 23 Aug 2016 17:12:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fabio.estevam@....com
Cc:     vz@...ia.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3] net: lpc_eth: Check clk_prepare_enable() error

From: Fabio Estevam <fabio.estevam@....com>
Date: Tue, 23 Aug 2016 09:48:20 -0300

> clk_prepare_enable() may fail, so we should better check its return
> value and propagate it in the case of failure
> 
> While at it, replace __lpc_eth_clock_enable() with a plain
> clk_prepare_enable/clk_disable_unprepare() call in order to
> simplify the code.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@....com>
> Acked-by: Vladimir Zapolskiy <vz@...ia.com>
> ---
> Changes since v2:
> - Make sure to call clk_put on the new error path (Vladimir)

Applied.