netdev - Re: [PATCH -next] tipc: use kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2471868-3aee-9549-bda0-33559da2519f@gmail.com>
Date:   Wed, 24 Aug 2016 18:18:47 +0800
From:   Ying Xue <ying.xue0@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     weiyj.lk@...il.com, jon.maloy@...csson.com, weiyongjun1@...wei.com,
        netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH -next] tipc: use kfree_skb() instead of kfree()

On 08/24/2016 02:00 PM, David Miller wrote:
> From: "Xue, Ying" <Ying.Xue@...driver.com>
> Date: Wed, 24 Aug 2016 02:47:32 +0000
> 
>> Acked-by: Ying Xue <ying.xue@...driver.com>
> 
> Please do not ACK patches like this.
> 
> If you quote the patch with no demarcation in the initial column for
> the quoted text, like so:
> 
>> From: Wei Yongjun [mailto:weiyj.lk@...il.com] 
>> Sent: Wednesday, August 24, 2016 7:01 AM
>> To: Jon Maloy; Xue, Ying; David S. Miller
>> Cc: Wei Yongjun; netdev@...r.kernel.org; tipc-discussion@...ts.sourceforge.net
>> Subject: [PATCH -next] tipc: use kfree_skb() instead of kfree()
>>
>> From: Wei Yongjun <weiyongjun1@...wei.com>
>>
>> Use kfree_skb() instead of kfree() to free sk_buff.
>  ...
> 
> then it makes it look like _you_ are posting this patch, so it ends up
> again in patchwork and your ACK gets lost.
> 
> I truly feel like I've told you this at least one time already before,
> so please fix your quoting so that it adheres to the list posting
> standards used by everyone else here.
> 

Sorry for bringing such inconvenience for you.
I am sure I will strictly follow the standards in the future.

Regards,
Ying

> Thank you.
>