netdev - Re: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for ndo_set_vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160825.162405.408460591169068270.davem@redhat.com>
Date:   Thu, 25 Aug 2016 16:24:05 -0700 (PDT)
From:   David Miller <davem@...hat.com>
To:     hariprasad@...lsio.com
Cc:     netdev@...r.kernel.org, leedom@...lsio.com, nirranjan@...lsio.com
Subject: Re: [PATCH net-next 1/2] cxgb4/cxgb4vf: Add support for
 ndo_set_vf_vlan

From: Hariprasad Shenai <hariprasad@...lsio.com>
Date: Wed, 24 Aug 2016 12:20:33 +0530

> +	dev_info(pi->adapter->pdev_dev,
> +		 "Setting Vlan %u to VF [%d]\n", vlan, vf);
> +	dev_info(pi->adapter->pdev_dev,
> +		 "The VF [%d] interface needs to brought down and up, "
> +		 "if VF is already up and running, for VST to work\n", vf);

Requiring the user to do something like this for the feature to work
correctly is not reasonable at all.

I want you to seriously consider rearchitecting this whole facility.