netdev - Re: [PATCH] net: systemport: Fix ordering in intrl2_*_mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2016 16:53:04 -0700 (PDT)
From:   David Miller <davem@...hat.com>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: systemport: Fix ordering in intrl2_*_mask_clear
 macro

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed, 24 Aug 2016 14:21:41 -0700

> Since we keep shadow copies of which interrupt sources are enabled
> through the intrl2_*_mask_{set,clear} macros, make sure that the
> ordering in which we do these two operations: update the copy, then
> unmask the register is correct.
> 
> This is not currently a problem because we actually do not use them, but
> we will in a subsequent patch optimizing register accesses, so better be
> safe here.
> 
> Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> David,
> 
> This is intentionally targetting the "net-next" tree since it is
> not yet a problem, yet this is still technically a bugfix. No need
> to backport this to -stable or anything.

Fair enough, applied to net-next.

Thanks!