netdev - Re: [PATCH v2 2/6] cgroup: add support for eBPF programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2016 14:56:11 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Daniel Mack <daniel@...que.org>
Cc:     kbuild-all@...org, htejun@...com, daniel@...earbox.net, ast@...com,
        davem@...emloft.net, kafai@...com, fw@...len.de,
        pablo@...filter.org, harald@...hat.com, netdev@...r.kernel.org,
        sargun@...gun.me, Daniel Mack <daniel@...que.org>
Subject: Re: [PATCH v2 2/6] cgroup: add support for eBPF programs

Hi Daniel,

[auto build test WARNING on net-next/master]
[also build test WARNING on v4.8-rc3 next-20160824]
[cannot apply to linus/master linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Daniel-Mack/Add-eBPF-hooks-for-cgroups/20160825-042759
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   include/linux/compiler.h:230:8: sparse: attribute 'no_sanitize_address': unknown attribute
>> kernel/bpf/cgroup.c:46:17: sparse: incompatible types in comparison expression (different address spaces)
>> kernel/bpf/cgroup.c:46:17: sparse: incompatible types in comparison expression (different address spaces)
   kernel/bpf/cgroup.c:97:17: sparse: incompatible types in comparison expression (different address spaces)
   kernel/bpf/cgroup.c:147:16: sparse: incompatible types in comparison expression (different address spaces)

vim +46 kernel/bpf/cgroup.c

    30				continue;
    31	
    32			bpf_prog_put(cgrp->bpf.prog[type]);
    33			static_branch_dec(&cgroup_bpf_enabled_key);
    34		}
    35	
    36		rcu_read_unlock();
    37	}
    38	
    39	void cgroup_bpf_inherit(struct cgroup *cgrp, struct cgroup *parent)
    40	{
    41		unsigned int type;
    42	
    43		rcu_read_lock();
    44	
    45		for (type = 0; type < __MAX_BPF_ATTACH_TYPE; type++)
  > 46			rcu_assign_pointer(cgrp->bpf.prog_effective[type],
    47				rcu_dereference(parent->bpf.prog_effective[type]));
    48	
    49		rcu_read_unlock();
    50	}
    51	
    52	/**
    53	 * __cgroup_bpf_update() - Update the pinned program of a cgroup, and
    54	 *                         propagate the change to descendants

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation