netdev - Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1472116596.2877.23.camel@suse.com>
Date:   Thu, 25 Aug 2016 11:16:36 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Alban Bedel <alban.bedel@...onic-design.de>
Cc:     Freddy Xin <freddy@...x.com.tw>, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM

On Wed, 2016-08-24 at 16:40 +0200, Alban Bedel wrote:
> On Wed, 24 Aug 2016 16:30:39 +0200
> Oliver Neukum <oneukum@...e.com> wrote:
> 
> > On Wed, 2016-08-24 at 15:52 +0200, Alban Bedel wrote:

> > > +       if (block != data)
> > > +               kfree(block);  
> > 
> > And if block == dta, what frees the memory?
> 
> In this case this function didn't allocate any memory, so there is
> nothing to free.

Hi,

I see. kfree() has a check for NULL, so you could drop the
test, but it doesn't matter much either way.

	Regards
		Oliver