netdev - Re: [PATCH] net: hns: dereference ppe_cb->ppe_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160826.114544.331469797150439600.davem@davemloft.net>
Date:   Fri, 26 Aug 2016 11:45:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        lisheng011@...wei.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hns: dereference ppe_cb->ppe_common_cb if it is
 non-null

From: Colin King <colin.king@...onical.com>
Date: Thu, 25 Aug 2016 07:51:10 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> ppe_cb->ppe_common_cb is being dereferenced before a null check is
> being made on it.  If ppe_cb->ppe_common_cb is null then we end up
> with a null pointer dereference when assigning dsaf_dev.  Fix this
> by moving the initialisation of dsaf_dev once we know
> ppe_cb->ppe_common_cb is OK to dereference.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.