netdev - Re: [PATCH v1 1/1 net-next] 8139cp: Fix one possible deadloop in cp_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160825.170259.1411639595965936537.davem@redhat.com>
Date:   Thu, 25 Aug 2016 17:02:59 -0700 (PDT)
From:   David Miller <davem@...hat.com>
To:     fgao@...vckh6395k16k5.yundunddos.com
Cc:     dwmw2@...radead.org, netdev@...r.kernel.org, gfree.wind@...il.com
Subject: Re: [PATCH v1 1/1 net-next] 8139cp: Fix one possible deadloop in
 cp_rx_poll

From: fgao@...ai8.com
Date: Thu, 25 Aug 2016 09:45:39 +0800

> From: Gao Feng <fgao@...ai8.com>
> 
> When cp_rx_poll does not get enough packet, it will check the rx
> interrupt status again. If so, it will jumpt to rx_status_loop again.
> But the goto jump resets the rx variable as zero too.
> 
> As a result, it causes one possible deadloop. Assume this case,
> rx_status_loop only gets the packet count which is less than budget,
> and (cpr16(IntrStatus) & cp_rx_intr_mask) condition is always true.
> It causes the deadloop happens and system is blocked.
> 
> Signed-off-by: Gao Feng <fgao@...ai8.com>

Makes sense, applied, thanks.